[chore] track markdown-link-check with renovate #36552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
mx-psi
approved these changes
Nov 26, 2024
There was a problem hiding this comment.
LGTM, but the job was skipped on this PR: https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/12030896224/job/33539336146?pr=36552 could we test before merging? (maybe on a draft PR split off from this one)
Signed-off-by: Moritz Wiesinger <[email protected]>
|
@mx-psi i did a test change in a markdown file to get a run triggered. installation looks good although the tool errors out so i'll maybe revert back to the pinned version for now |
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
|
@mx-psi all green with the older markdown link check version |
mx-psi
pushed a commit
that referenced
this pull request
Nov 28, 2024
Reverts #36555. After the update of the version the check is failing: https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/12068945579/job/33655141758#step:10:16 The PR introduced the dependency had the version pinned: #36552
shivanthzen
pushed a commit
to shivanthzen/opentelemetry-collector-contrib
that referenced
this pull request
Dec 5, 2024
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description This PR adds markdown-link-check to the tracked dependencies of renovate. It achieves that by using the [`customManagers:githubActionsVersions`](https://docs.renovatebot.com/presets-customManagers/#custommanagersgithubactionsversions) renovate preset that enables user to update arbitrary versions in github actions files without having to maintain their own regex for them. <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes open-telemetry#36259 <!--Describe what testing was performed and which tests were added.--> #### Testing This setup is already in use in the dynatrace collector distro and works great: [latest update PR](Dynatrace/dynatrace-otel-collector#382), [renovate config](https://github.com/Dynatrace/dynatrace-otel-collector/blob/07e4662f92b0cadfb311eca74c9269c1c1598634/renovate.json#L6) --------- Signed-off-by: Moritz Wiesinger <[email protected]>
shivanthzen
pushed a commit
to shivanthzen/opentelemetry-collector-contrib
that referenced
this pull request
Dec 5, 2024
…-telemetry#36586) Reverts open-telemetry#36555. After the update of the version the check is failing: https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/12068945579/job/33655141758#step:10:16 The PR introduced the dependency had the version pinned: open-telemetry#36552
ZenoCC-Peng
pushed a commit
to ZenoCC-Peng/opentelemetry-collector-contrib
that referenced
this pull request
Dec 6, 2024
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description This PR adds markdown-link-check to the tracked dependencies of renovate. It achieves that by using the [`customManagers:githubActionsVersions`](https://docs.renovatebot.com/presets-customManagers/#custommanagersgithubactionsversions) renovate preset that enables user to update arbitrary versions in github actions files without having to maintain their own regex for them. <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes open-telemetry#36259 <!--Describe what testing was performed and which tests were added.--> #### Testing This setup is already in use in the dynatrace collector distro and works great: [latest update PR](Dynatrace/dynatrace-otel-collector#382), [renovate config](https://github.com/Dynatrace/dynatrace-otel-collector/blob/07e4662f92b0cadfb311eca74c9269c1c1598634/renovate.json#L6) --------- Signed-off-by: Moritz Wiesinger <[email protected]>
ZenoCC-Peng
pushed a commit
to ZenoCC-Peng/opentelemetry-collector-contrib
that referenced
this pull request
Dec 6, 2024
…-telemetry#36586) Reverts open-telemetry#36555. After the update of the version the check is failing: https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/12068945579/job/33655141758#step:10:16 The PR introduced the dependency had the version pinned: open-telemetry#36552
sbylica-splunk
pushed a commit
to sbylica-splunk/opentelemetry-collector-contrib
that referenced
this pull request
Dec 17, 2024
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description This PR adds markdown-link-check to the tracked dependencies of renovate. It achieves that by using the [`customManagers:githubActionsVersions`](https://docs.renovatebot.com/presets-customManagers/#custommanagersgithubactionsversions) renovate preset that enables user to update arbitrary versions in github actions files without having to maintain their own regex for them. <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes open-telemetry#36259 <!--Describe what testing was performed and which tests were added.--> #### Testing This setup is already in use in the dynatrace collector distro and works great: [latest update PR](Dynatrace/dynatrace-otel-collector#382), [renovate config](https://github.com/Dynatrace/dynatrace-otel-collector/blob/07e4662f92b0cadfb311eca74c9269c1c1598634/renovate.json#L6) --------- Signed-off-by: Moritz Wiesinger <[email protected]>
sbylica-splunk
pushed a commit
to sbylica-splunk/opentelemetry-collector-contrib
that referenced
this pull request
Dec 17, 2024
…-telemetry#36586) Reverts open-telemetry#36555. After the update of the version the check is failing: https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/12068945579/job/33655141758#step:10:16 The PR introduced the dependency had the version pinned: open-telemetry#36552
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds markdown-link-check to the tracked dependencies of renovate. It achieves that by using the
customManagers:githubActionsVersionsrenovate preset that enables user to update arbitrary versions in github actions files without having to maintain their own regex for them.Link to tracking issue
Fixes #36259
Testing
This setup is already in use in the dynatrace collector distro and works great: latest update PR, renovate config