Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] run codeowner check on PRs #36285

Merged
merged 3 commits into from
Dec 6, 2024

Conversation

atoulme
Copy link
Contributor

@atoulme atoulme commented Nov 9, 2024

Description

An attempt to run codeowner check through the pull_request_target goal.
An other attempt is #36023.

@atoulme atoulme requested a review from a team as a code owner November 9, 2024 07:22
@atoulme atoulme requested a review from ChrsMark November 9, 2024 07:22
@atoulme atoulme force-pushed the run_codeowners_on_pr branch from 4c32a0f to 7fedd14 Compare November 9, 2024 07:34
@atoulme
Copy link
Contributor Author

atoulme commented Nov 9, 2024

Unfortunately, this cannot be tested without being merged since it has so many permission requirements.

@songy23 songy23 added the ci-cd CI, CD, testing, build issues label Nov 11, 2024
@songy23 songy23 requested a review from evan-bradley November 11, 2024 14:29
Copy link
Contributor

@evan-bradley evan-bradley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me. I'm assuming githubgen doesn't do any kind of unsafe reading on input files, right?

Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Nov 30, 2024
@evan-bradley evan-bradley removed the Stale label Dec 3, 2024
@evan-bradley
Copy link
Contributor

@atoulme I'll merge this after the release unless you have any concerns.

@evan-bradley evan-bradley merged commit d797bf5 into open-telemetry:main Dec 6, 2024
158 checks passed
@github-actions github-actions bot added this to the next release milestone Dec 6, 2024
@atoulme atoulme deleted the run_codeowners_on_pr branch December 10, 2024 21:49
sbylica-splunk pushed a commit to sbylica-splunk/opentelemetry-collector-contrib that referenced this pull request Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-cd CI, CD, testing, build issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants