Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[receiver/prometheusremotewrite] Add component skeleton #35295

Merged
merged 1 commit into from
Oct 1, 2024
Merged

[receiver/prometheusremotewrite] Add component skeleton #35295

merged 1 commit into from
Oct 1, 2024

Conversation

ArthurSens
Copy link
Member

Description:

Add skeleton for Prometheus Remote-Write Receiver. With the release of PrometheusRemoteWritev2, there's commitment from the Prometheus team to implement and maintain this component :)

prometheus/prometheus#12633 (comment)

Link to tracking Issue: #33782

@ArthurSens ArthurSens requested a review from a team as a code owner September 19, 2024 14:59
dashpole
dashpole reviewed Sep 19, 2024
View reviewed changes
.github/CODEOWNERS Outdated Show resolved Hide resolved
@ArthurSens
Copy link
Member Author

Yeah, I noticed all this wrong stuff in the owners but I'm struggling to understand how the automation works here. I was hoping to see CI failures and then a useful error message that shows me how to fix it :)

@dashpole
Copy link
Contributor

Try running the make commands listed under "First PR" here? https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/CONTRIBUTING.md#adding-new-components

@ArthurSens ArthurSens mentioned this pull request Sep 19, 2024
Merged
@ArthurSens
Copy link
Member Author

Try running the make commands listed under "First PR" here? https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/CONTRIBUTING.md#adding-new-components

I just did, it solved a few problems but apparently didn't re-generate the README file. Let me see what CI tells me now

@ArthurSens ArthurSens force-pushed the prw-receiver branch 2 times, most recently from 477d6f6 to 38dbe7c Compare September 20, 2024 07:57
@ArthurSens ArthurSens force-pushed the prw-receiver branch 3 times, most recently from 5ebc9f3 to 46e1fb3 Compare September 25, 2024 19:27
@dashpole
Copy link
Contributor

You should add a changelog entry

@ArthurSens ArthurSens force-pushed the prw-receiver branch 3 times, most recently from 9f3d23e to 6c46113 Compare September 25, 2024 21:02
@ArthurSens
Copy link
Member Author

Finally got the CI green 😁, should be ready for a review

@ArthurSens
Copy link
Member Author

hey @dashpole, just double checking... is anything missing from my side here?

@dashpole dashpole added the ready to merge Code review completed; ready to merge by maintainers label Oct 1, 2024
@mx-psi mx-psi merged commit 6d1d0a3 into open-telemetry:main Oct 1, 2024
163 checks passed
@github-actions github-actions bot added this to the next release milestone Oct 1, 2024
@ArthurSens ArthurSens deleted the prw-receiver branch October 1, 2024 14:57
@codeboten
Copy link
Contributor

@ArthurSens have you already started the process to join the OpenTelemetry org? See https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/CONTRIBUTING.md#becoming-a-code-owner for more details

@ArthurSens
Copy link
Member Author

@ArthurSens have you already started the process to join the OpenTelemetry org? See https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/CONTRIBUTING.md#becoming-a-code-owner for more details

No I did not, totally forgot about that lol

I'm start the process now

@ArthurSens ArthurSens mentioned this pull request Oct 1, 2024
Closed
6 tasks
@codeboten codeboten mentioned this pull request Oct 1, 2024
Merged
jriguera pushed a commit to springernature/opentelemetry-collector-contrib that referenced this pull request Oct 4, 2024
@ArthurSens @jriguera
[receiver/prometheusremotewrite] Add component skeleton (open-telemet…
1633959 
…ry#35295)

**Description:** 

Add skeleton for Prometheus Remote-Write Receiver. With the release of
PrometheusRemoteWritev2, there's commitment from the Prometheus team to
implement and maintain this component :)


prometheus/prometheus#12633 (comment)

**Link to tracking Issue:**
open-telemetry#33782

Signed-off-by: Arthur Silva Sens <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrsMark ChrsMark ChrsMark left review comments

@dashpole dashpole dashpole approved these changes

Assignees

@mx-psi mx-psi

Labels
ready to merge Code review completed; ready to merge by maintainers reports/distributions/contrib.yaml
Projects
None yet
Milestone
v0.111.0
Development

Successfully merging this pull request may close these issues.
5 participants
@ArthurSens @dashpole @codeboten @ChrsMark @mx-psi