[pkg/ottl] Add grammar utility to extract paths from statements #35174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
bogdandrutu,
evan-bradley,
kentquirk and
TylerHelmuth
edmocosta
changed the title
|
@edmocosta I'm holding off on reviewing this until it is marked Ready, but I am interested. |
…lector-contrib into ottl_add_grammar_paths_visitor
I was running a few more tests and forgot to mark it as ready. Thanks @TylerHelmuth! |
edmocosta
force-pushed
the
ottl_add_grammar_paths_visitor
branch
from
9ff99fb to
055d362
Compare
TylerHelmuth
approved these changes
Sep 27, 2024
TylerHelmuth
added
the
Skip Changelog
|
Hi @TylerHelmuth! please let me know if there is anything left before it can be merged. Thank you! |
|
@evan-bradley please review |
evan-bradley
approved these changes
Oct 7, 2024
There was a problem hiding this comment.
Looks good to me, sorry for the long delay in reviewing this. Thank you @edmocosta!
shalper2
pushed a commit
to shalper2/opentelemetry-collector-contrib
that referenced
this pull request
Oct 7, 2024
…-telemetry#35174) **Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> This PR is part of open-telemetry#29017, and adds a grammar utility to allow extracting `ottl.path` from parsed statements and expressions. The new functions will power the context inferrer utility (see [draft](open-telemetry#35050)), which implementation will basically gather all declared statement's `Path.Context`, and choose the highest priority one. For the statements rewriter utility purpose, it changes the `grammar.go` file including a new field `Pos lexer.Position` into the `ottl.path` struct. This value is automatically set by the `participle` lexer and holds the path's offsets, being useful for identifying their positions in the raw statement, without using regexes an being coupled to the grammar's definition. **Additional changes**: This proposal uses the visitor pattern to gather all path's from the parsed statements. Considering the grammar's custom error mechanism (`checkForCustomError`) also works with a similar pattern, I've added the visitor implementation as part of the grammar objects, and refactored all `checkForCustomError` functions to be part of a validator visitor. Differently of the current implementation, it joins and displays all errors at once instead of one by one, IMO, it's specially useful for statements with more than one error, for example: `set(name, int(2), float(1))`. *** We can change it back do be error-by-error if necessary. *** If modifying the custom validator is not desired, I can roll those changes back keeping only the necessary code to extract the path's + `Pos` field. **Link to tracking Issue:** open-telemetry#29017 **Testing:** Unit tests were added **Documentation:** No changes
ghost
pushed a commit
to sematext/opentelemetry-collector-contrib
that referenced
this pull request
Oct 9, 2024
…-telemetry#35174) **Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> This PR is part of open-telemetry#29017, and adds a grammar utility to allow extracting `ottl.path` from parsed statements and expressions. The new functions will power the context inferrer utility (see [draft](open-telemetry#35050)), which implementation will basically gather all declared statement's `Path.Context`, and choose the highest priority one. For the statements rewriter utility purpose, it changes the `grammar.go` file including a new field `Pos lexer.Position` into the `ottl.path` struct. This value is automatically set by the `participle` lexer and holds the path's offsets, being useful for identifying their positions in the raw statement, without using regexes an being coupled to the grammar's definition. **Additional changes**: This proposal uses the visitor pattern to gather all path's from the parsed statements. Considering the grammar's custom error mechanism (`checkForCustomError`) also works with a similar pattern, I've added the visitor implementation as part of the grammar objects, and refactored all `checkForCustomError` functions to be part of a validator visitor. Differently of the current implementation, it joins and displays all errors at once instead of one by one, IMO, it's specially useful for statements with more than one error, for example: `set(name, int(2), float(1))`. *** We can change it back do be error-by-error if necessary. *** If modifying the custom validator is not desired, I can roll those changes back keeping only the necessary code to extract the path's + `Pos` field. **Link to tracking Issue:** open-telemetry#29017 **Testing:** Unit tests were added **Documentation:** No changes
This was referenced Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR is part of #29017, and adds a grammar utility to allow extracting
ottl.pathfrom parsed statements and expressions. The new functions will power the context inferrer utility (see draft), which implementation will basically gather all declared statement'sPath.Context, and choose the highest priority one.For the statements rewriter utility purpose, it changes the
grammar.gofile including a new fieldPos lexer.Positioninto theottl.pathstruct. This value is automatically set by theparticiplelexer and holds the path's offsets, being useful for identifying their positions in the raw statement, without using regexes an being coupled to the grammar's definition.Additional changes:
This proposal uses the visitor pattern to gather all path's from the parsed statements. Considering the grammar's custom error mechanism (
checkForCustomError) also works with a similar pattern, I've added the visitor implementation as part of the grammar objects, and refactored allcheckForCustomErrorfunctions to be part of a validator visitor. Differently of the current implementation, it joins and displays all errors at once instead of one by one, IMO, it's specially useful for statements with more than one error, for example:set(name, int(2), float(1)).* We can change it back do be error-by-error if necessary.
* If modifying the custom validator is not desired, I can roll those changes back keeping only the necessary code to extract the path's +
Posfield.Link to tracking Issue: #29017
Testing: Unit tests were added
Documentation: No changes