[ottl/pkg] Add support for locale in the Time converter #35107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edmocosta
requested review from
TylerHelmuth,
bogdandrutu and
evan-bradley
as code owners
| @@ -1519,6 +1519,16 @@ Examples: | |||
| - `Time("2012-11-01T22:08:41+0000 EST", "%Y-%m-%dT%H:%M:%S%z %Z")` | |||
| - `Time("2023-05-26 12:34:56", "%Y-%m-%d %H:%M:%S", "America/New_York")` | |||
|
|
|||
| `locale` specifies the input language of the `target` value. It is used to interpret timestamp values written in a specific language, | |||
There was a problem hiding this comment.
Please add something that conveys that when not set english is the local that gets used.
…lector-contrib into ottl_time_func_locale_support # Conflicts: # pkg/ottl/ottlfuncs/func_time.go
Hi @TylerHelmuth, I've rebased and adapted it to the latest changes to avoid parsing the c-time layout in every operation (#35129). Thanks! |
TylerHelmuth
approved these changes
Sep 20, 2024
jriguera
pushed a commit
to springernature/opentelemetry-collector-contrib
that referenced
this pull request
Oct 4, 2024
…ry#35107) **Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> Added support for locale in the `Time` converter, so it can parse timestamps written in non-english languages. The new `locale` parameter's value is optional, and can be specified as: `Time("Febrero 25 lunes, 2002, 02:03:04 p.m.", "%B %d %A, %Y, %r", "America/New_York", "es-ES")` The value must be a well-formed BCP-47 language tag, and a known [CLDR](https://cldr.unicode.org) v45 locale. **Link to tracking Issue:** open-telemetry#32978 **Testing:** Unit tests **Documentation:** ottl/README was updated to include the new optional `locale` parameter.
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Added support for locale in the
Timeconverter, so it can parse timestamps written in non-english languages.The new
localeparameter's value is optional, and can be specified as:Time("Febrero 25 lunes, 2002, 02:03:04 p.m.", "%B %d %A, %Y, %r", "America/New_York", "es-ES")The value must be a well-formed BCP-47 language tag, and a known CLDR v45 locale.
Link to tracking Issue: #32978
Testing: Unit tests
Documentation: ottl/README was updated to include the new optional
localeparameter.