[receiver/webhookevent] Webhook event timestamp #33733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shalper2
force-pushed
the
webhook-event-timestamp
branch
from
9ab97ed to
4286ffa
Compare
shalper2
force-pushed
the
webhook-event-timestamp
branch
3 times, most recently
from
2b3f947 to
0ec0081
Compare
|
@open-telemetry/collector-contrib-approvers |
shalper2
force-pushed
the
webhook-event-timestamp
branch
from
0ec0081 to
2d6fc25
Compare
crobert-1
approved these changes
Jul 9, 2024
jpkrohling
changed the title
shalper2
force-pushed
the
webhook-event-timestamp
branch
from
2d6fc25 to
338d9be
Compare
|
@atoulme mind taking a quick look? |
shalper2
force-pushed
the
webhook-event-timestamp
branch
3 times, most recently
from
82b124d to
4d9d835
Compare
|
@dashpole hey there, looks like this PR got assigned to you, would you mind taking a quick look at it please? |
shalper2
force-pushed
the
webhook-event-timestamp
branch
2 times, most recently
from
5a99d0b to
1773157
Compare
atoulme
approved these changes
Jul 29, 2024
crobert-1
added
the
ready to merge
shalper2
force-pushed
the
webhook-event-timestamp
branch
from
1773157 to
c425a7c
Compare
shalper2
force-pushed
the
webhook-event-timestamp
branch
3 times, most recently
from
b1a6269 to
78295f5
Compare
shalper2
force-pushed
the
webhook-event-timestamp
branch
from
78295f5 to
e2999ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Added the optional ObservedTimestamp field to log record created when an event is received. Also fixed some erroneously capitalized letters in two error descriptions.
Link to tracking Issue: 33702
Testing: built collector and passed unittests
Documentation: None