Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes ISSUE-19095: Allow to set AWS session duration #19096

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fixes ISSUE-19095: Allow to set AWS session duration #19096

wants to merge 3 commits into from
+14 −1

Conversation

KylixSerg
Copy link
Contributor

When using the assumeRole connection type for ingestion pipelines involving AWS services, pipelines that might take >1hour fail due to the default 1h duration of the boto session, one way of solving this issue is to allow the users to optionally set the duration of the session to take full use of the maximum session duration aws role setting.

Describe your changes:

Fixes

I worked on ... because ...

Type of change:

  • [ X] Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • [ X] My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

ISSUE-19095: Allow to set AWS session duration
61c2cd9 
When using the assumeRole connection type for ingestion pipelines involving
AWS services, pipelines that might take >1hour fail due to the default 1h
duration of the boto session, one way of solving this issue is to allow
the users to optionally set the duration of the session to take full use
of the maximum session duration aws role setting.
@KylixSerg KylixSerg requested a review from a team as a code owner December 16, 2024 13:31
@github-actions GitHub Actions
Copy link
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@IceS2 IceS2 added the safe to test Add this label to run secure Github workflows on PRs label Dec 17, 2024
@github-actions GitHub Actions
Copy link
Contributor

The Python checkstyle failed.

Please run make py_format and py_format_check in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Python code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

@IceS2
Copy link
Contributor

IceS2 commented Dec 17, 2024

Hey @KylixSerg , thanks a lot for the PR.
Could you please fix the Python Checkstyle?

Thanks!

@KylixSerg
Copy link
Contributor Author

KylixSerg commented Dec 17, 2024 •
edited
Loading

@IceS2 Thanks for checking this PR as well, done.

I would like to point out that this PR and the other one #19098 can be exclusive, I am fine with either one being merged, as they pretty much achieve the same goal, though this one will have a cap of 12h which is the max duration you can set on an IAM session (I don't think we need to worry about that now)

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ingestion'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KylixSerg @IceS2