Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(e2e): Explore page tests #19074

Merged
merged 4 commits into from
Dec 16, 2024
Merged

test(e2e): Explore page tests #19074

merged 4 commits into from
Dec 16, 2024

Conversation

pranita09
Copy link
Contributor

@pranita09 pranita09 commented Dec 15, 2024 •
edited
Loading

Describe your changes:

I worked on Explore page e2e tests.

  • Check listing of entities when index is dataAsset
  • Check listing of entities when index is all

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@github-actions GitHub Actions
Copy link
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@karanh37 karanh37 added the safe to test Add this label to run secure Github workflows on PRs label Dec 16, 2024
@github-actions GitHub Actions
Copy link
Contributor

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 63%
 63.88% (40067/62724) 40.39% (16043/39719) 43.06% (4804/11156)

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 16, 2024

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@pranita09 pranita09 marked this pull request as ready for review December 16, 2024 07:12
@karanh37 karanh37 merged commit 57e814c into open-metadata:main Dec 16, 2024
14 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karanh37 karanh37 karanh37 approved these changes

@ShaileshParmar11 ShaileshParmar11 Awaiting requested review from ShaileshParmar11

@chirag-madlani chirag-madlani Awaiting requested review from chirag-madlani

@Sachin-chaurasiya Sachin-chaurasiya Awaiting requested review from Sachin-chaurasiya

Assignees
No one assigned
Labels
safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pranita09 @karanh37