Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NullPointer for Workflow Setting #19053

Merged
merged 1 commit into from
Dec 14, 2024
Merged

Fix NullPointer for Workflow Setting #19053

merged 1 commit into from
Dec 14, 2024

Conversation

mohityadav766
Copy link
Contributor

Describe your changes:

  • Fixed null pointer for WorkflowSettings
  • Added test for Workflow setting

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@mohityadav766 mohityadav766 self-assigned this Dec 14, 2024
@mohityadav766 mohityadav766 requested a review from a team as a code owner December 14, 2024 05:45
@github-actions github-actions bot added backend safe to test Add this label to run secure Github workflows on PRs labels Dec 14, 2024
@mohityadav766 mohityadav766 changed the title Fix Settings Cache for Workflow Setting Fix NullPointer for Workflow Setting Dec 14, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 14, 2024

Quality Gate Passed Quality Gate passed for 'open-metadata-ingestion'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@mohityadav766 mohityadav766 merged commit 0164643 into main Dec 14, 2024
12 of 19 checks passed
@mohityadav766 mohityadav766 deleted the fix-setting-cache branch December 14, 2024 19:46
mohityadav766 added a commit that referenced this pull request Dec 16, 2024
@mohityadav766
Fix Settings Cache (#19053)
d2d7212 
(cherry picked from commit 0164643)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshach harshach harshach approved these changes

@IceS2 IceS2 Awaiting requested review from IceS2

Assignees

@mohityadav766 mohityadav766

Labels
backend safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mohityadav766 @harshach