Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui): sync search value with url and state value #19050

Merged
merged 6 commits into from
Dec 16, 2024
Merged

fix(ui): sync search value with url and state value #19050

merged 6 commits into from
Dec 16, 2024

Conversation

chirag-madlani
Copy link
Collaborator

@chirag-madlani chirag-madlani commented Dec 13, 2024 •
edited
Loading

Describe your changes:

Fixes: Issue with user search sync

Issue

usersearch.mov

fixed

Screen.Recording.2024-12-13.at.7.19.35.PM.mov

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@github-actions github-actions bot added safe to test Add this label to run secure Github workflows on PRs UI UI specific issues labels Dec 13, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 13, 2024 •
edited
Loading

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 63%
 63.87% (40075/62747) 40.38% (16040/39724) 43.06% (4805/11160)

karanh37
karanh37 previously approved these changes Dec 16, 2024
View reviewed changes
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 16, 2024

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@chirag-madlani chirag-madlani merged commit 4d30c83 into main Dec 16, 2024
15 of 17 checks passed
@chirag-madlani chirag-madlani deleted the fix-user-search branch December 16, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karanh37 karanh37 karanh37 approved these changes

@ShaileshParmar11 ShaileshParmar11 Awaiting requested review from ShaileshParmar11

@Sachin-chaurasiya Sachin-chaurasiya Awaiting requested review from Sachin-chaurasiya

Assignees
No one assigned
Labels
safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chirag-madlani @karanh37