Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat : Support for Announcements listing in Activity Feed Tab and Announcement Tab in Service page #18993

Open
wants to merge 31 commits into
base: main
Choose a base branch
from

Conversation

shrushti2000
Copy link
Contributor

@shrushti2000 shrushti2000 commented Dec 10, 2024

  1. Added Announcements listing functionality in the Activity Feed Tab along with CRUD functionality.
  2. Added Announcements Tab in Service page which has Announcements listing with CRUD functionality.
  3. Redirect users to Announcements tab in Service page or subtab in Activity Feed respectively when clicked on the active announcement card.
  4. Removed the Announcements Drawer.
  5. Removed Announcement option from Manage Button

Note: The implementation for the count of announcements is currently not included in this PR. This will be added once the necessary backend changes are completed and available.

Announcements Listing in Activity Feed

Screen.Recording.2024-12-16.at.8.31.49.PM.2.3.1.mov

Announcements Listing in Service Page

Screen.Recording.2024-12-16.at.8.33.13.PM.1.1.1.mov

Update Manage Button
Screenshot 2024-12-16 at 8 45 54 PM

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@shrushti2000 shrushti2000 changed the title Feat : Support for Announcements listing in Activity Feed Tab and Announcement Tab in Service page WIP : Support for Announcements listing in Activity Feed Tab and Announcement Tab in Service page Dec 10, 2024
Copy link
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

Copy link
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

Copy link
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

Copy link
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants