Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: Combined index on offset and eventTime in changeEvent table #18922

Merged
merged 6 commits into from
Dec 4, 2024
Merged

FIX: Combined index on offset and eventTime in changeEvent table #18922

merged 6 commits into from
Dec 4, 2024

Conversation

Siddhanttimeline
Copy link
Contributor

@Siddhanttimeline Siddhanttimeline commented Dec 4, 2024 •
edited
Loading

Describe your changes:

  1. Removed single-column index event_time_index.
  2. Added composite index idx_offset_event_time, which is better suited for queries involving both offset and eventTime.

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@Siddhanttimeline Siddhanttimeline added backend safe to test Add this label to run secure Github workflows on PRs labels Dec 4, 2024
@Siddhanttimeline Siddhanttimeline requested a review from a team December 4, 2024 12:41
@Siddhanttimeline Siddhanttimeline self-assigned this Dec 4, 2024
pmbrull
pmbrull previously approved these changes Dec 4, 2024
View reviewed changes
@harshach harshach merged commit e770ba8 into main Dec 4, 2024
14 of 16 checks passed
@harshach harshach deleted the change-event-improvements branch December 4, 2024 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshach harshach harshach approved these changes

@pmbrull pmbrull Awaiting requested review from pmbrull

@mohityadav766 mohityadav766 Awaiting requested review from mohityadav766

Assignees

@Siddhanttimeline Siddhanttimeline

Labels
backend safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Siddhanttimeline @harshach @pmbrull