Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ui): add gifsicle as it's needed for image-webpack-loader #18919

Merged
merged 1 commit into from
Dec 4, 2024
Merged

chore(ui): add gifsicle as it's needed for image-webpack-loader #18919

merged 1 commit into from
Dec 4, 2024

Conversation

chirag-madlani
Copy link
Collaborator

Describe your changes:

Fixes: Need gifsicle for image-webpack-loader more context here: tcoopman/image-webpack-loader#233

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@github-actions github-actions bot added safe to test Add this label to run secure Github workflows on PRs UI UI specific issues labels Dec 4, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 4, 2024

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 63%
 63.74% (40309/63235) 40.23% (16043/39883) 42.58% (4799/11270)

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 4, 2024

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@ShaileshParmar11 ShaileshParmar11 merged commit 30196f4 into main Dec 4, 2024
16 of 18 checks passed
@ShaileshParmar11 ShaileshParmar11 deleted the fix-gifsicle branch December 4, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShaileshParmar11 ShaileshParmar11 ShaileshParmar11 approved these changes

@aniketkatkar97 aniketkatkar97 aniketkatkar97 approved these changes

@karanh37 karanh37 Awaiting requested review from karanh37

@Sachin-chaurasiya Sachin-chaurasiya Awaiting requested review from Sachin-chaurasiya

Assignees
No one assigned
Labels
safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chirag-madlani @aniketkatkar97 @ShaileshParmar11