Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MINOR: update lineage column with new design #18862

Merged
merged 5 commits into from
Dec 2, 2024
Merged

MINOR: update lineage column with new design #18862

merged 5 commits into from
Dec 2, 2024

Conversation

Ashish8689
Copy link
Contributor

@Ashish8689 Ashish8689 commented Nov 29, 2024 •
edited
Loading

Describe your changes:

  • I worked on updating lineage column with new design

New :

image
Screen.Recording.2024-12-01.at.10.10.53.PM.mov

Old :

image

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@Ashish8689 Ashish8689 self-assigned this Nov 29, 2024
@Ashish8689 Ashish8689 added the UI UI specific issues label Nov 29, 2024
@github-actions github-actions bot added the safe to test Add this label to run secure Github workflows on PRs label Nov 29, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 29, 2024 •
edited
Loading

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 63%
 63.75% (40315/63236) 40.23% (16043/39883) 42.59% (4799/11268)

karanh37
karanh37 previously approved these changes Dec 1, 2024
View reviewed changes
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 1, 2024

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@Ashish8689 Ashish8689 merged commit 1ea52d7 into main Dec 2, 2024
14 of 16 checks passed
@Ashish8689 Ashish8689 deleted the lineage-column-design branch December 2, 2024 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karanh37 karanh37 karanh37 approved these changes

@ShaileshParmar11 ShaileshParmar11 Awaiting requested review from ShaileshParmar11 ShaileshParmar11 is a code owner

@chirag-madlani chirag-madlani Awaiting requested review from chirag-madlani chirag-madlani is a code owner

@Sachin-chaurasiya Sachin-chaurasiya Awaiting requested review from Sachin-chaurasiya Sachin-chaurasiya is a code owner

Assignees

@Ashish8689 Ashish8689

Labels
safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ashish8689 @karanh37