Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NoSchedule as ScheduleType for Slack App #18715

Merged
merged 8 commits into from
Nov 22, 2024
Merged

NoSchedule as ScheduleType for Slack App #18715

merged 8 commits into from
Nov 22, 2024

Conversation

Siddhanttimeline
Copy link
Contributor

@Siddhanttimeline Siddhanttimeline commented Nov 21, 2024

Describe your changes:

Fixes

For noScheduleApps, schedule and recent runs will not be shown

Screenshot 2024-11-21 at 5 56 58 PM

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

Copy link

sonarcloud bot commented Nov 21, 2024

Copy link
Contributor

github-actions bot commented Nov 21, 2024

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 63%
63.59% (39854/62670) 40.19% (15840/39409) 42.35% (4728/11164)

@Siddhanttimeline Siddhanttimeline changed the title [WIP] NoSchedule as ScheduleType for Slack App NoSchedule as ScheduleType for Slack App Nov 21, 2024
Copy link

sonarcloud bot commented Nov 21, 2024

@harshach harshach merged commit 702c34c into main Nov 22, 2024
17 of 26 checks passed
@harshach harshach deleted the fix-slack-app branch November 22, 2024 06:29
harshach pushed a commit that referenced this pull request Nov 24, 2024
* fix: NoSchedule as scheduleType for Slack App

* fix: remove callback url from the config.

* no render of schedule for noSchedule type

* fix: Migrations and add ScheduleType.NoSchedule

* fix: Migrations

---------

Co-authored-by: karanh37 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants