Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MINOR: doc(mongodb): mongodb+srv connection scheme #18712

Merged
merged 4 commits into from
Nov 21, 2024
Merged

MINOR: doc(mongodb): mongodb+srv connection scheme #18712

merged 4 commits into from
Nov 21, 2024

Conversation

sushi30
Copy link
Contributor

@sushi30 sushi30 commented Nov 20, 2024

  • added information about the mongodb+srv connection scheme
  • added link to atlas guide for getting the connection string

Describe your changes:

Fixes

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@sushi30
doc(mongodb): mongodb+srv connection scheme
03dadc9 
- added information about the mongodb+srv connection scheme
- added link to atlas guide for getting the connection string
@github-actions github-actions bot added Ingestion safe to test Add this label to run secure Github workflows on PRs labels Nov 20, 2024
@sushi30 sushi30 enabled auto-merge (squash) November 20, 2024 15:24
@sushi30 sushi30 added documentation Improvements or additions to documentation and removed Ingestion labels Nov 21, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 21, 2024

Quality Gate Passed Quality Gate passed for 'open-metadata-ingestion'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@sushi30 sushi30 merged commit d089ffa into main Nov 21, 2024
21 of 26 checks passed
@sushi30 sushi30 deleted the mongodb-srv-connection-doc branch November 21, 2024 18:42
harshach pushed a commit that referenced this pull request Nov 24, 2024
@sushi30 @harshach
doc(mongodb): mongodb+srv connection scheme (#18712)
0526f1e 
- added information about the mongodb+srv connection scheme
- added link to atlas guide for getting the connection string
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmbrull pmbrull pmbrull approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation Ingestion safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sushi30 @pmbrull