Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MINOR: Move from Date to LocalDate for thread safe operations #18679

Merged
merged 5 commits into from
Nov 20, 2024
Merged

MINOR: Move from Date to LocalDate for thread safe operations #18679

merged 5 commits into from
Nov 20, 2024

Conversation

TeddyCr
Copy link
Contributor

@TeddyCr TeddyCr commented Nov 18, 2024

Describe your changes:

  • Move from Date to LocalDate for thread safe operations
    image

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

Bug fix

  • I have added a test that covers the exact scenario we are fixing. For complex issues, comment the issue number in the test for future reference.

@TeddyCr TeddyCr requested a review from a team as a code owner November 18, 2024 16:04
@github-actions github-actions bot added Ingestion safe to test Add this label to run secure Github workflows on PRs labels Nov 18, 2024
@github-actions GitHub Actions
Copy link
Contributor

The Java checkstyle failed.

Please run mvn spotless:apply in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Java code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

The Java checkstyle failed.

Please run mvn spotless:apply in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Java code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

pmbrull
pmbrull previously approved these changes Nov 18, 2024
View reviewed changes
@pmbrull pmbrull merged commit 91de99a into open-metadata:main Nov 20, 2024
14 of 21 checks passed
TeddyCr added a commit that referenced this pull request Nov 20, 2024
@TeddyCr
MINOR: Move from Date to LocalDate for thread safe operations (#18679)
fe94709 
* fix: move from Date to LocalDate for thread safe operations

* style: ran java linting

* fix: invalid range in test case

(cherry picked from commit 91de99a)
TeddyCr added a commit that referenced this pull request Nov 20, 2024
@TeddyCr
MINOR: Move from Date to LocalDate for thread safe operations (#18679)
1ae378d 
* fix: move from Date to LocalDate for thread safe operations

* style: ran java linting

* fix: invalid range in test case

(cherry picked from commit 91de99a)
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 20, 2024

Quality Gate Passed Quality Gate passed for 'open-metadata-ingestion'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

harshach pushed a commit that referenced this pull request Nov 24, 2024
@TeddyCr @harshach
MINOR: Move from Date to LocalDate for thread safe operations (#18679)
6bb05e1 
* fix: move from Date to LocalDate for thread safe operations

* style: ran java linting

* fix: invalid range in test case
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sushi30 sushi30 sushi30 approved these changes

@pmbrull pmbrull pmbrull left review comments

Assignees
No one assigned
Labels
Ingestion safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TeddyCr @sushi30 @pmbrull