MINOR: Improve PeriodicBatchEntityTrigger Workflows performance #18664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Ingestion
safe to test
IceS2
changed the title
|
pmbrull
approved these changes
Nov 17, 2024
|
The test that is failing for the CI is being fixed here: https://github.com/open-metadata/OpenMetadata/pull/18640/files |
harshach
reviewed
Nov 17, 2024
| @@ -40,6 +40,10 @@ private WorkflowHandler(OpenMetadataApplicationConfig config) { | |||
| ProcessEngineConfiguration processEngineConfiguration = | |||
| new StandaloneProcessEngineConfiguration() | |||
| .setAsyncExecutorActivate(true) | |||
| .setAsyncExecutorCorePoolSize(50) | |||
There was a problem hiding this comment.
should these be configurable?
There was a problem hiding this comment.
I think they should, but we can iterate on that after having a decent default for production load.
I was thinking about having a Workflows Setting kind of thing within the OpenMetadata settings.
What do you think?
IceS2
added a commit
that referenced
this pull request
Nov 18, 2024
* Update default configurations * Refactor how we call the main Workflow in order to increase performance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to Increase the performance of the Flowable Workflows (Mainly for the PeriodicBatchEntityTrigger), we are:
Updating the default Async Executor Flowable configurations to handle more workload
The default configurations are pretty bad for an asset intensive production environment and thus we are updating them.
Refactoring how we call the MainWorkflow from the TriggerWorkflow
We are now relying on
CallActivityto call the MainWorkflow instead of doing it programatically through aJavaDelegateon aServiceTask.This is pretty important for the PeriodicBatchEntityTrigger, where we are now relying on
MultiInstanceLoopCharacteristicsfor the concurrent task execution instead of dealing with it manually.It is a BPMN2.0 natural way of solving this issues that I didn't realized it would work for a whole workflow before.
As a plus, it also takes care of waiting for the MainWorkflow to finish before finishing the TriggerWorkflow.
Small fix to avoid patching an Entity if the updated Certification would be the same as the one they currently have.
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>