Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor: supporting PR for UI/UX improvement in DQ #18663

Merged
merged 16 commits into from
Nov 21, 2024
Merged

Minor: supporting PR for UI/UX improvement in DQ #18663

merged 16 commits into from
Nov 21, 2024

Conversation

ShaileshParmar11
Copy link
Contributor

@ShaileshParmar11 ShaileshParmar11 commented Nov 15, 2024 •
edited
Loading

Describe your changes:

This is the supporting PR for UI/UX improvement in Data quality dashboard & overview tab

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@github-actions github-actions bot added safe to test Add this label to run secure Github workflows on PRs UI UI specific issues labels Nov 15, 2024
@ShaileshParmar11 ShaileshParmar11 self-assigned this Nov 19, 2024
@ShaileshParmar11 ShaileshParmar11 marked this pull request as ready for review November 19, 2024 14:18
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 21, 2024

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@ShaileshParmar11 ShaileshParmar11 merged commit cda201b into main Nov 21, 2024
13 of 17 checks passed
@ShaileshParmar11 ShaileshParmar11 deleted the dq-improvement-supporting-pr branch November 21, 2024 11:11
harshach pushed a commit that referenced this pull request Nov 24, 2024
@ShaileshParmar11 @harshach
Minor: supporting PR for UI/UX improvement in DQ (#18663)
213e308 
* Minor: supporting PR for UI/UX improvement in DQ

* updated feedback

* move incidents tab to data observabilty tab

* fixed failing unit test

* fixed failing unit test

* fixed AUT failure!

* fixed failing aut

* minor fixes

* minor fix

* updated icon

* fixed failing unit test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chirag-madlani chirag-madlani chirag-madlani approved these changes

@karanh37 karanh37 Awaiting requested review from karanh37 karanh37 is a code owner

@Sachin-chaurasiya Sachin-chaurasiya Awaiting requested review from Sachin-chaurasiya Sachin-chaurasiya is a code owner

Assignees

@ShaileshParmar11 ShaileshParmar11

Labels
safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ShaileshParmar11 @chirag-madlani