MINOR - PII Scanner tests and log levels #17686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Ingestion
safe to test
pmbrull
commented
Sep 3, 2024
| @@ -226,36 +225,3 @@ def get_database_names(self) -> Iterable[str]: | |||
| except Exception as exc: | |||
| logger.debug(f"Failed to fetch database names {exc}") | |||
| logger.debug(traceback.format_exc()) | |||
|
|
|||
| def get_table_entities(self, database): | |||
There was a problem hiding this comment.
I don't think it was used at all @ulixius9, I only see in _iter the call to the ES search
pmbrull
commented
Sep 3, 2024
| @@ -138,7 +137,7 @@ def _iter(self, *_, **__) -> Iterable[Either[ProfilerSourceAndEntity]]: | |||
| service_name=None, | |||
| schema_name=schema_name, | |||
| table_name=table_name, | |||
| fields="tableProfilerConfig", | |||
| fields=",".join(self._get_fields()), | |||
There was a problem hiding this comment.
centralized how we are getting the required fields
|
TeddyCr
approved these changes
Sep 4, 2024
OnkarVO7
approved these changes
Sep 4, 2024
pmbrull
added a commit
that referenced
this pull request
Sep 4, 2024
* MINOR - PII Scanner tests and log levels * MINOR - PII Scanner tests and log levels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes:
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>