Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes 17648: add tags and description for tableau published data source #17678

Merged
merged 6 commits into from
Sep 3, 2024
Merged

fixes 17648: add tags and description for tableau published data source #17678

merged 6 commits into from
Sep 3, 2024

Conversation

nicor88
Copy link
Contributor

@nicor88 nicor88 commented Sep 2, 2024 •
edited
Loading

Describe your changes:

Fixes #17648

In addition introduce TableauDataModelTag to deal with tags in published data sources in tableau.

Notes

  • I added the support to fetch hasExtracts for data models, this is quite relevant to know, I just don't know how to show this field in the UI - can be done in the next iteration

TODO

  • add unit tests
  • configure dev environment properly

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@nicor88 nicor88 requested a review from a team as a code owner September 2, 2024 19:46
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 2, 2024

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@nicor88 nicor88 changed the title feat: fixes 17648 - add tags and description for tableau published data source fixes 17648: add tags and description for tableau published data source Sep 2, 2024
@nicor88 nicor88 marked this pull request as draft September 2, 2024 20:07
OnkarVO7
OnkarVO7 suggested changes Sep 3, 2024
View reviewed changes
Copy link
Contributor

@OnkarVO7 OnkarVO7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HI @nicor88 thanks for contribution 🚀 and for raising the PR. Left some minor comments overall it looks good

ingestion/src/metadata/ingestion/source/dashboard/tableau/queries.py Outdated Show resolved Hide resolved
ingestion/src/metadata/ingestion/source/dashboard/tableau/models.py Show resolved Hide resolved
ingestion/src/metadata/ingestion/source/dashboard/tableau/metadata.py Outdated Show resolved Hide resolved
ingestion/src/metadata/ingestion/source/dashboard/tableau/metadata.py Outdated Show resolved Hide resolved
ingestion/src/metadata/ingestion/source/dashboard/tableau/metadata.py Outdated Show resolved Hide resolved
ingestion/src/metadata/ingestion/source/dashboard/tableau/metadata.py Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 3, 2024

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 3, 2024

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 3, 2024

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@OnkarVO7 OnkarVO7 added the safe to test Add this label to run secure Github workflows on PRs label Sep 3, 2024
@nicor88 nicor88 requested a review from OnkarVO7 September 3, 2024 07:24
@nicor88 nicor88 marked this pull request as ready for review September 3, 2024 07:24
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 3, 2024

The Python checkstyle failed.

Please run make py_format and py_format_check in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Python code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 3, 2024

Quality Gate Passed Quality Gate passed for 'open-metadata-ingestion'

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
21.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@pmbrull pmbrull merged commit 235337d into open-metadata:main Sep 3, 2024
15 of 16 checks passed
@nicor88 nicor88 deleted the feat/tableau_data_sources_tags branch September 3, 2024 09:38
OnkarVO7 pushed a commit that referenced this pull request Sep 3, 2024
@nicor88 @OnkarVO7
fixes 17648: add tags and description for tableau published data sour…
d068a59 
…ce (#17678)

* tableau data-source tags and description

* tweaks

* PR review

* change test description

* black formatting
Prajwal214 pushed a commit to Prajwal214/OpenMetadata that referenced this pull request Sep 3, 2024
@nicor88
fixes 17648: add tags and description for tableau published data sour…
13a6c9d 
…ce (open-metadata#17678)

* tableau data-source tags and description

* tweaks

* PR review

* change test description

* black formatting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OnkarVO7 OnkarVO7 OnkarVO7 approved these changes

Assignees
No one assigned
Labels
Ingestion safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ingest tags and descriptions for TableauPublishedDatasource
3 participants
@nicor88 @OnkarVO7 @pmbrull