Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix some entities not visible in Following widget #17665

Merged
merged 2 commits into from
Sep 2, 2024

Conversation

Ashish8689
Copy link
Contributor

@Ashish8689 Ashish8689 commented Sep 2, 2024

Describe your changes:

  • I worked on fixing some entities not visible in Following widget
  • added playwright test

Issue :

image image

Resolved :
image

image

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

Copy link
Contributor

github-actions bot commented Sep 2, 2024

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 65%
65.11% (37175/57099) 41.56% (14779/35559) 43.91% (4524/10302)

Copy link

sonarcloud bot commented Sep 2, 2024

Copy link

cypress bot commented Sep 2, 2024

openmetadata    Run #34914

Run Properties:  status check passed Passed #34914  •  git commit 95b877a7e9: added some extra spacing in quick filter
Project openmetadata
Branch Review following-widget-fix
Run status status check passed Passed #34914
Run duration 06m 03s
Commit git commit 95b877a7e9: added some extra spacing in quick filter
Committer Ashish Gupta
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 12
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 46
View all changes introduced in this branch ↗︎

@Ashish8689 Ashish8689 merged commit 00fe839 into main Sep 2, 2024
19 checks passed
@Ashish8689 Ashish8689 deleted the following-widget-fix branch September 2, 2024 17:42
harshach pushed a commit that referenced this pull request Sep 2, 2024
* fix some entities not visible in Following widget

* added some extra spacing in quick filter
Ashish8689 added a commit that referenced this pull request Sep 4, 2024
* fix some entities not visible in Following widget

* added some extra spacing in quick filter

(cherry picked from commit 00fe839)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e This will trigger e2e test workflows safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants