Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

playwright: migrate incident manager test to playwright #17657

Merged
merged 4 commits into from
Sep 3, 2024
Merged

playwright: migrate incident manager test to playwright #17657

merged 4 commits into from
Sep 3, 2024

Conversation

ShaileshParmar11
Copy link
Contributor

@ShaileshParmar11 ShaileshParmar11 commented Sep 1, 2024 •
edited
Loading

playwright: migrate incident manager test to playwright

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@github-actions github-actions bot added e2e:Observability e2e:DataAssets UI UI specific issues safe to test Add this label to run secure Github workflows on PRs labels Sep 1, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 1, 2024

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 65%
 65.11% (37183/57110) 41.56% (14779/35559) 43.92% (4526/10306)

@ShaileshParmar11 ShaileshParmar11 marked this pull request as ready for review September 2, 2024 10:39
@ShaileshParmar11 ShaileshParmar11 self-assigned this Sep 2, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 2, 2024

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@ShaileshParmar11 ShaileshParmar11 enabled auto-merge (squash) September 3, 2024 04:44
@chirag-madlani chirag-madlani merged commit 0a9e0d0 into main Sep 3, 2024
19 of 24 checks passed
@chirag-madlani chirag-madlani deleted the pw-incident-manager branch September 3, 2024 06:55
Prajwal214 pushed a commit to Prajwal214/OpenMetadata that referenced this pull request Sep 3, 2024
@ShaileshParmar11
playwright: migrate incident manager test to playwright (open-metadat…
6363765 
…a#17657)

* playwright: migrate incident manager test to playwright

* migrate remaining test to playwright

* added serial mode to prevent load while deploying pipeline
ShaileshParmar11 added a commit that referenced this pull request Sep 10, 2024
@ShaileshParmar11
playwright: migrate incident manager test to playwright (#17657)
b931152 
* playwright: migrate incident manager test to playwright

* migrate remaining test to playwright

* added serial mode to prevent load while deploying pipeline
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chirag-madlani chirag-madlani chirag-madlani approved these changes

@karanh37 karanh37 Awaiting requested review from karanh37 karanh37 is a code owner

@Sachin-chaurasiya Sachin-chaurasiya Awaiting requested review from Sachin-chaurasiya Sachin-chaurasiya is a code owner

Assignees

@ShaileshParmar11 ShaileshParmar11

Labels
e2e:Observability safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ShaileshParmar11 @chirag-madlani