Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor: added support for edit assign button in incident manager #17646

Merged
merged 3 commits into from
Aug 30, 2024
Merged

Minor: added support for edit assign button in incident manager #17646

merged 3 commits into from
Aug 30, 2024

Conversation

ShaileshParmar11
Copy link
Contributor

@ShaileshParmar11 ShaileshParmar11 commented Aug 30, 2024 •
edited
Loading

Screen.Recording.2024-08-30.at.3.22.24.PM.mov

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@github-actions github-actions bot added UI UI specific issues e2e:Observability e2e:DataAssets safe to test Add this label to run secure Github workflows on PRs labels Aug 30, 2024
@github-actions GitHub Actions
Copy link
Contributor

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 65%
 65.08% (37143/57074) 41.54% (14751/35511) 43.9% (4523/10302)

@ShaileshParmar11 ShaileshParmar11 added the e2e This will trigger e2e test workflows label Aug 30, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 30, 2024

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@cypress Cypress
Copy link

cypress bot commented Aug 30, 2024

openmetadata    Run #34911

Run Properties:  status check passed Passed #34911  •  git commit 0c52ed35f0: minor fix
Project openmetadata
Branch Review assignee-edit-button
Run status status check passed Passed #34911
Run duration 14m 04s
Commit git commit 0c52ed35f0: minor fix
Committer Shailesh Parmar
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 12
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 113
View all changes introduced in this branch ↗︎

@chirag-madlani chirag-madlani enabled auto-merge (squash) August 30, 2024 10:50
@chirag-madlani chirag-madlani merged commit b618bb5 into main Aug 30, 2024
19 checks passed
@chirag-madlani chirag-madlani deleted the assignee-edit-button branch August 30, 2024 11:17
ShaileshParmar11 added a commit that referenced this pull request Aug 30, 2024
@ShaileshParmar11
Minor: added support for edit assign button in incident manager (#17646)
614c42e 
* Minor: Added support for assignee edit in incident manager

* minor change

* minor fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chirag-madlani chirag-madlani chirag-madlani approved these changes

@karanh37 karanh37 Awaiting requested review from karanh37 karanh37 is a code owner

@Sachin-chaurasiya Sachin-chaurasiya Awaiting requested review from Sachin-chaurasiya Sachin-chaurasiya is a code owner

Assignees
No one assigned
Labels
e2e:Observability e2e This will trigger e2e test workflows safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ShaileshParmar11 @chirag-madlani