Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(e2e): speed up playwright with 2 machines #17630

Merged
merged 2 commits into from
Aug 29, 2024
Merged

ci(e2e): speed up playwright with 2 machines #17630

merged 2 commits into from
Aug 29, 2024

Conversation

chirag-madlani
Copy link
Collaborator

Describe your changes:

Fixes

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@github-actions github-actions bot added devops safe to test Add this label to run secure Github workflows on PRs UI UI specific issues labels Aug 29, 2024
akash-jain-10
akash-jain-10 approved these changes Aug 29, 2024
View reviewed changes
Copy link
Collaborator

@akash-jain-10 akash-jain-10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@chirag-madlani chirag-madlani merged commit d36f0e1 into main Aug 29, 2024
16 checks passed
@chirag-madlani chirag-madlani deleted the ci-boost-playw branch August 29, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akash-jain-10 akash-jain-10 akash-jain-10 approved these changes

@harshach harshach Awaiting requested review from harshach harshach is a code owner

@tutte tutte Awaiting requested review from tutte tutte is a code owner

Assignees
No one assigned
Labels
devops safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chirag-madlani @akash-jain-10