Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pass the correct argument to get_reference_by_email for dbt ingestion #17613

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

nicor88
Copy link
Contributor

@nicor88 nicor88 commented Aug 28, 2024

Describe your changes:

This issue fix this error on dbt ingestion

line 173, in get_dbt_owner
    owner = self.metadata.get_reference_by_email(name=dbt_owner)
            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
TypeError: OMetaUserMixin.get_reference_by_email() got an unexpected keyword argument 'name'

passing the right named argument, because name is not an arg of get_reference_by_email,

Notes

  • there should be enough unit test to cover the behavior of get_reference_by_email
  • I didn't find any reference to this issue, when searching the issues.

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@nicor88
Copy link
Contributor Author

nicor88 commented Aug 28, 2024

@OnkarVO7 FYI.

Copy link
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@OnkarVO7 OnkarVO7 added the safe to test Add this label to run secure Github workflows on PRs label Aug 28, 2024
Copy link

sonarcloud bot commented Aug 28, 2024

@ulixius9 ulixius9 merged commit 5eae1e3 into open-metadata:main Aug 28, 2024
19 of 27 checks passed
@nicor88 nicor88 deleted the chore/fix_owner_email_dbt branch August 28, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ingestion safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants