Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: Fixed owner not updating from dbt if owners field has an empty list set in db #17610

Merged
merged 2 commits into from
Aug 28, 2024

Conversation

OnkarVO7
Copy link
Contributor

Describe your changes:

Fixed owner not updating from dbt if owners field has an empty list set in db

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@OnkarVO7 OnkarVO7 requested a review from a team as a code owner August 28, 2024 08:27
@github-actions github-actions bot added backend Ingestion safe to test Add this label to run secure Github workflows on PRs labels Aug 28, 2024
mohityadav766
mohityadav766 previously approved these changes Aug 28, 2024
@nicor88
Copy link
Contributor

nicor88 commented Aug 28, 2024

Thanks for the fix @OnkarVO7 💯

@nicor88
Copy link
Contributor

nicor88 commented Aug 28, 2024

Do you aim to include this in 1.5.1 release?

@OnkarVO7 OnkarVO7 requested a review from mohityadav766 August 28, 2024 09:00
@mohityadav766 mohityadav766 merged commit d6eb4fa into main Aug 28, 2024
12 of 14 checks passed
@mohityadav766 mohityadav766 deleted the dbt_owner_empty_list_fix branch August 28, 2024 09:01
OnkarVO7 added a commit that referenced this pull request Aug 28, 2024
… list set in db (#17610)

* Fixed owner not updating from dbt for empty list

* fix table get
Copy link

sonarcloud bot commented Aug 28, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Ingestion safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants