Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove sorting of tags #17604

Merged
merged 3 commits into from
Aug 28, 2024
Merged

remove sorting of tags #17604

merged 3 commits into from
Aug 28, 2024

Conversation

karanh37
Copy link
Contributor

Describe your changes:

Remove the sorting from UI performed before patch operation.
It was previously added here - #9055

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

harshach
harshach previously approved these changes Aug 28, 2024
Copy link
Contributor

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 65%
65.09% (37137/57058) 41.56% (14750/35487) 43.92% (4523/10299)

Copy link

sonarcloud bot commented Aug 28, 2024

@chirag-madlani chirag-madlani merged commit dfafca8 into main Aug 28, 2024
15 of 17 checks passed
@chirag-madlani chirag-madlani deleted the tags-sort-fix branch August 28, 2024 06:22
karanh37 added a commit that referenced this pull request Aug 28, 2024
* remove sorting of tags from ui

* add playwright tests

* add playwright test for tags in children

(cherry picked from commit dfafca8)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e This will trigger e2e test workflows safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants