Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MINOR: Add pagination to entity history versions #17587

Merged
merged 2 commits into from
Aug 28, 2024
Merged

MINOR: Add pagination to entity history versions #17587

merged 2 commits into from
Aug 28, 2024

Conversation

IceS2
Copy link
Contributor

@IceS2 IceS2 commented Aug 26, 2024

Adds Pagination through LIMIT/OFFSET to listEntityVersions to avoid bringing a lot of data into memory.

Type of change:

  • Improvement

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@github-actions github-actions bot added backend Ingestion safe to test Add this label to run secure Github workflows on PRs labels Aug 26, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 26, 2024

Quality Gate Passed Quality Gate passed for 'open-metadata-ingestion'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@IceS2 IceS2 marked this pull request as ready for review August 28, 2024 07:00
@IceS2 IceS2 requested a review from a team as a code owner August 28, 2024 07:00
@mohityadav766 mohityadav766 merged commit b8af201 into main Aug 28, 2024
22 of 23 checks passed
@mohityadav766 mohityadav766 deleted the add-pagination-to-entity-history-versions branch August 28, 2024 09:08
mohityadav766 pushed a commit that referenced this pull request Aug 28, 2024
@IceS2 @mohityadav766
MINOR: Add pagination to entity history versions (#17587)
13fd18d 
* Add pagination to EntityHistory Versions

* Fix endless loop

(cherry picked from commit b8af201)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohityadav766 mohityadav766 mohityadav766 approved these changes

Assignees
No one assigned
Labels
backend Ingestion safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IceS2 @mohityadav766