Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Tags removal from the tables in data assets detail page not working properly. #8555

Closed
aniketkatkar97 opened this issue Nov 7, 2022 · 3 comments
Assignees
Labels
UI UI specific issues

Comments

@aniketkatkar97
Copy link
Member

aniketkatkar97 commented Nov 7, 2022

Affected module
Does it impact the UI, backend or Ingestion Framework?
UI

Describe the bug
A clear and concise description of what the bug is.
The order of the displayed tags is different from the order in data causing the issue.

To Reproduce

Screenshots or steps to reproduce

Screen.Recording.2022-11-07.at.3.43.02.PM.mov

Expected behavior
A clear and concise description of what you expected to happen.

Version:

  • OS: [e.g. iOS]
  • Python version:
  • OpenMetadata version: [e.g. 0.8]
  • OpenMetadata Ingestion package version: [e.g. openmetadata-ingestion[docker]==XYZ]

Additional context
Add any other context about the problem here.

@harshach
Copy link
Collaborator

@Sachin-chaurasiya is this a issue?

@aniketkatkar97
Copy link
Member Author

@harshach, while checking this in detail with the help of @chirag-madlani, It turned out to be a UI bug where the order of the displayed tags was different from the data causing the issue. I will take care of this bug.

@aniketkatkar97 aniketkatkar97 added UI UI specific issues and removed backend labels Nov 28, 2022
@aniketkatkar97 aniketkatkar97 moved this to 🏗 In progress in Release 0.13.1 Nov 28, 2022
@aniketkatkar97 aniketkatkar97 changed the title Backend: Tables PATCH API not working properly UI: Tags removal from the tables in data assets detail page not working properly. Nov 28, 2022
aniketkatkar97 added a commit that referenced this issue Nov 30, 2022
* Fixed Error thrown while removing tags from data asset details page

* Fixed bug where user were not able to remove the tags on Dashboard Details page

* Changes in MlModelFeaturesList component:
- Tag removal bug fix
- Removed tailwind use and replaced with antd
- Code optimisation
- Localisation changes

* Moved height and width styling from app.less to size.less

* Moved tags sorting functionality to a common util function

* Removed redundant labels in en-us and replaced with common reusable label

* Removed unnecessary code

* localisation changes

* Added unit tests for added functions in CommonUtils and DashboardDetailsUtils

* Added missing localisation changes for MlModelFeaturesList
@aniketkatkar97
Copy link
Member Author

Fixed in #9055

Repository owner moved this from 🏗 In progress to 🔖 Ready in Release 0.13.1 Dec 2, 2022
@harshach harshach moved this from 🔖 Ready to ✅ Done in Release 0.13.1 Dec 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UI UI specific issues
Projects
No open projects
Status: Done
Development

No branches or pull requests

2 participants