Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: unnecessary use of fmt.Sprintf #973

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

chore: unnecessary use of fmt.Sprintf #973

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion modules/nodata/config/service/mockcfg.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ func GetMockCfgFromDB() map[string]*cmodel.NodataConfig {
return ret
}

q := fmt.Sprintf("SELECT id,name,obj,obj_type,metric,tags,dstype,step,mock FROM mockcfg")
q := "SELECT id,name,obj,obj_type,metric,tags,dstype,step,mock FROM mockcfg"
rows, err := dbConn.Query(q)
if err != nil {
log.Println("db.query error, mockcfg", err)
Expand Down
8 changes: 4 additions & 4 deletions modules/transfer/http/debug_http.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,10 @@
package http

import (
"fmt"
"github.com/open-falcon/falcon-plus/modules/transfer/sender"
"net/http"
"strings"

"github.com/open-falcon/falcon-plus/modules/transfer/sender"
)

func configDebugHttpRoutes() {
Expand All @@ -29,7 +29,7 @@ func configDebugHttpRoutes() {

argsLen := len(args)
if argsLen < 1 {
w.Write([]byte(fmt.Sprintf("bad args\n")))
w.Write([]byte("bad args\n"))
return
}

Expand All @@ -41,7 +41,7 @@ func configDebugHttpRoutes() {
case "graph":
result = strings.Join(sender.GraphConnPools.Proc(), "\n")
default:
result = fmt.Sprintf("bad args, module not exist\n")
result = "bad args, module not exist\n"
}
w.Write([]byte(result))
})
Expand Down