-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump devops tests to include checks for notebook badges #1453
base: main
Are you sure you want to change the base?
Conversation
I need someone else to rerun demos with numba. |
@slayoo only one notebook should be incorrect: it's performance comparison Don't know why the others are wrong, I change them many times. Will try once again. |
@AgnieszkaZaba, Numba is enabled when running the notebooks on CI. There are no GPUs available on CI, but we have |
Ok, you're right. I'm still waiting for Jupyter to finish running :) |
Ah, I didn't realise you are referring to running the GPU tests locally on a machine without GPU to generate notebook output. That is indeed meaningless. Perhaps, we could convert this notebook into a .py script so that it would be stored in the repo, but without output? |
Hmm I feel like this output is important and should be stored somewhere. Not necessarily in notebook. I'm trying to run it on Colab. Keep disconnecting me but program is still running and giving results, so maybe will be ok. |
The output is also persistently stored in the UJ AP repo (pages 29-30): https://www.ap.uj.edu.pl/diplomas/attachments/file/download/168064/ |
That is great! I will add this link to the notebook. |
Thank you! |
@slayoo thanks for rebasing, I didn't succeed with that. Right now I'm trying to run notebooks but after 5 hours still do not have results |
This was a merge. For PR branches, merges are usually straightforward, and thus much simpler than rebasing. Rebasing works best for the always-clean
Which notebooks take so long? |
aa ok, still dont fully understand, but I will get there.
From deJong_Mackay_et_al_2023 fig9 and figs_3_4_5 |
|
For both notebook it was around 11 hours 😮 |
No description provided.