Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

switching from "n" to "multiplicity" for attribute key #1123

Merged
merged 16 commits into from
Aug 29, 2023
Merged

switching from "n" to "multiplicity" for attribute key #1123

merged 16 commits into from
Aug 29, 2023

Conversation

slayoo
Copy link
Member

@slayoo slayoo commented Aug 26, 2023 •
edited
Loading

This is the first in a series of upcoming PRs aimed at improving readability of the code, and aimed at correcting some suboptimal early design decisions. The next PRs will address:

  • switching from volumes to masses as super-particle attributes
  • renaming "thd" to "dry-air potential temperature"
  • renaming "q" and "r" to "water vapour mixing ratio", etc

@slayoo slayoo requested a review from abulenok August 27, 2023 11:15
@slayoo slayoo added this pull request to the merge queue Aug 29, 2023
Merged via the queue into open-atmos:main with commit 9f2c88e Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abulenok abulenok abulenok approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@slayoo @abulenok