Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new example based on Grabowski & Pawlowska 2023 (GRL) #1093

Merged
merged 32 commits into from
Sep 1, 2023
Merged

new example based on Grabowski & Pawlowska 2023 (GRL) #1093

merged 32 commits into from
Sep 1, 2023

Conversation

AgnieszkaMakulska
Copy link
Collaborator

No description provided.

@slayoo
Copy link
Member

slayoo commented Jun 30, 2023

closing and reopening to trigger build against current main branch

@slayoo slayoo closed this Jun 30, 2023
@slayoo slayoo reopened this Jun 30, 2023
@slayoo slayoo changed the title we added a new example folder new example based on Grabowski & Pawlowska 2023 (GRL) Jul 21, 2023
AgnieszkaMakulska and others added 19 commits August 28, 2023 12:52
@AgnieszkaMakulska
we added a new example folder
5062e1f
@AgnieszkaMakulska
fixed new line
d58b68b
@slayoo @AgnieszkaMakulska
one more newline fix
6274a0e
@AgnieszkaMakulska
we changed the list of examples
4781745
@AgnieszkaMakulska
added equilibrium supersaturation attribute and a draft of example no…
e19f8bb 
…tebook with figure 1
@AgnieszkaMakulska
added equilibrium saturation and colors indicating whether droplet is…
4d0c532 
… activated
@AgnieszkaMakulska
added figure 2
33968ac
@slayoo @AgnieszkaMakulska
add AA to .zenodo.json credits file
69f8388
@AgnieszkaMakulska
added standard deviation and rel. dispersion
c4ae69f
@AgnieszkaMakulska
added figure 4
2c391f6
@AgnieszkaMakulska
changed sampling to ConstantMultiplicity and corrected the mean volum…
3d1113c 
…e radius
@AgnieszkaMakulska
added new products: activation_filtered_product, particle_concentrati…
1c47be1 
…on_activated, mean_radius_activated
@AgnieszkaMakulska
added a new product for mean volume radius and updated the example "Y…
33a5420 
…ang_et_al_2018"
@AgnieszkaMakulska
added a new product and a new test for particle size standard deviation
33fba74
@AgnieszkaMakulska
used new standard deviation product in figure 4
ea7fdb0
@AgnieszkaMakulska
added a new test for particle size product
d2a6229
@AgnieszkaMakulska
added a test for figure 4 and rearranged code in example notebooks
be759c8
@AgnieszkaMakulska
changed the test for figure 4
91f5b38
@AgnieszkaMakulska
dt and n_sd no longer have default values
195d332
@AgnieszkaMakulska
Copy link
Collaborator Author

AgnieszkaMakulska commented Aug 28, 2023 •
edited
Loading

  • smoke test for figures 1,2,3
  • unit test for concentration
  • check out ripening product

@slayoo
Copy link
Member

slayoo commented Aug 29, 2023

  • tests for the order of lines on the plot (e.g., blue is below red, etc)

@slayoo slayoo marked this pull request as ready for review August 31, 2023 13:41
@slayoo slayoo added this pull request to the merge queue Sep 1, 2023
Merged via the queue into open-atmos:main with commit 42f8485 Sep 1, 2023
@slayoo slayoo mentioned this pull request Sep 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slayoo slayoo slayoo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AgnieszkaMakulska @slayoo