-
-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix tile size stats memory leak #861
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quality Gate passedIssues Measures |
https://github.com/onthegomap/planetiler/actions/runs/8531224355 ℹ️ Base Logs 6c41c38
ℹ️ This Branch Logs 7db687d
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a memory leak when generating TileSizeStats TSV output during a planetiler run. The jackson
ObjectWriter#writeValueAsString
methodJsonFactory#_getBufferRecycler()
which usesLockFreePool#acquireAndLinkPooled
to get aBufferRecycler
. This tried to share up to 4 recyclers between threads, but somewhere around z13-15 tile generation, it stops working and starts creating a newBufferRecycler
per row written, which ends up making a lot ofchar[]
instances, causing the JVM to run out of memory. This change uses a newCsvWriter
andObjectWriter
per thread so there's no race condition to cause out of control allocations.