GeometryPipeline #1118
Open
GeometryPipeline #1118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Full logs: https://github.com/onthegomap/planetiler/actions/runs/12212231803 |
|
Amazing, thanks for introducing this! I am playing a bit around with it and post things that come to mind below... |
|
First question, if I do features.polygon("forest")
.setPixelTolerance(0.0)
.setMinPixelSize(0.0)
.transformScaledGeometry(GeometryPipeline.simplifyDP(2.0 / 256));in the processFeature function, will setPixelTolerance have any effect? |
|
Chaikin works nicely features.polygon("waterway")
.setPixelTolerance(0.0)
.transformScaledGeometry(GeometryPipeline.smoothChaikin(3))
.setMinPixelSize(0.0);
|
|
One thing that I always found a little bit disturbing about Douglas Peucker simplification was that you get these sharp corners all over the place. Would the recommended way to remove those be something like this? features.polygon("waterway")
.setPixelTolerance(0.0)
.transformScaledGeometry(
GeometryPipeline.simplifyDP(1/256d)
.andThen(GeometryPipeline.smoothChaikin(1))
)
.setMinPixelSize(0.0);
} |
|
Thanks for taking a look!
transformScaledGeometry replaces simplification, but I added a utility so you can do
Yes that could work! You end up adding points back to remove the sharp corners. You could also add points back by just using a smaller DP tolerance, but adding them back with chaikin smoothing results in a globbier shape. You could also try |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new
feature.setGeometryPipeline()API that registers a function to transform the feature geometry scaled to tile coordinates at each zoom level (where 1=the width of a tile at that zoom level). This can take any function fromGeometrytoGeometryfor example:Also started a
GeometryPipelineclass that can be used to instantiate other transforms, for example:These can be chained using
andThen:This should open the door for more complex configuration parameters on each simplify method, as well as transforms like midpoint or Chakin smoothing.