Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement NSButton extension for OSX #287

Merged
merged 1 commit into from
Apr 21, 2016
Merged

implement NSButton extension for OSX #287

merged 1 commit into from
Apr 21, 2016

Conversation

jzau
Copy link
Contributor

@jzau jzau commented Apr 15, 2016

I am not sure if there's a way to combine UIButton with NSButton. So I didn't change UIButton+extension, for now, I just create a new file to implement NSButton as it doesn't have backgroundImage property but alternateImage instead.

@codecov-io
Copy link

Current coverage is 82.64%

Merging #287 into master will increase coverage by +0.50% as of e1b2537

@@            master    #287   diff @@
======================================
  Files           12      13     +1
  Stmts         1322    1406    +84
  Branches         0       0       
  Methods          0       0       
======================================
+ Hit           1086    1162    +76
  Partial          0       0       
- Missed         236     244     +8

Review entire Coverage Diff as of e1b2537

Powered by Codecov. Updated on successful CI builds.

@onevcat
Copy link
Owner

onevcat commented Apr 21, 2016

@JackyZh Sorry for the late reply!

Thanks for the pull request. It seems cool at first glance. I will take a look deeper later. Since the APIs of UIButton and NSButton are quite different, I guess it should be no problem to keep them separated. It will not be hard to combine them into one too, if we'd like to do so later.

Cheers.

@onevcat onevcat merged commit e78bb40 into onevcat:master Apr 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants