Move appear life cycle to placeholder #1510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And also ensure image setting on main thread
|
This is a workaround for #1508. But a real fix is still being waited from Apple. |
3 tasks
|
Please revert this change as it causes flickering every time swiftUI re-renders - see details at #1549 |
|
@onevcat ^ |
|
@hyouuu This fix was intended as a workaround of Apple's bug on iOS 14. However, the flickering seems to be a side effect. I will see how we can solve it. |
|
@onevcat yes the intention is well understood and appreciated - it's just the side effect is too much :) Hope you can find a more appropriate fix soon and thanks! |
skoduricg
pushed a commit
to rentpath/Kingfisher
that referenced
this pull request
Sep 24, 2021
Move appear life cycle to placeholder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And also ensure image setting on main thread