Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid crash even if a registry key incldues inconvertible characters #375

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

ashie
Copy link
Contributor

@ashie ashie commented Feb 22, 2024

When the registry key SOFTWARE\Microsoft\Windows\CurrentVersion\Uninstall contains inconvertible characters to internal encoding, require rubygems crashes. This patch avoids this issue.

Fixe #372

When the registry key `SOFTWARE\Microsoft\Windows\CurrentVersion\Uninstall`
contains inconvertible characters to internal encoding, `require rubygems`
crashes. This patch avoids this issue.

Fixe oneclick#372
@larskanis larskanis merged commit 815e11a into oneclick:master Apr 24, 2024
8 of 10 checks passed
@ashie ashie deleted the avoid-crash-on-non-ascii-regkey branch April 24, 2024 04:19
@ashie
Copy link
Contributor Author

ashie commented Apr 24, 2024

Thanks!

kenhys added a commit to kenhys/fluent-package-builder that referenced this pull request Jun 18, 2024
kenhys added a commit to kenhys/fluent-package-builder that referenced this pull request Jun 19, 2024
kenhys added a commit to kenhys/fluent-package-builder that referenced this pull request Jun 19, 2024
kenhys added a commit to fluent/fluent-package-builder that referenced this pull request Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants