[GPU] Fp8 compute backports #2266
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kealan-barbieri
added
platform:gpu-intel
atkassen
approved these changes
Dec 13, 2024
hidefromkgb
approved these changes
Dec 13, 2024
dzarukin
reviewed
Dec 13, 2024
| @@ -195,7 +207,13 @@ struct matmul_pd_t : public primitive_desc_t { | |||
| sc.group_dims_[0] == 1 | |||
| && K() % sc.group_dims_[1] == 0); | |||
| } else { | |||
| ok = ok && (mask == 0); | |||
| ok = ok | |||
There was a problem hiding this comment.
Here must be a check for fp8 versus classic quantization.
There was a problem hiding this comment.
I dont think it is required. With these changes gemm supports dst scales whenever dst is an integer or fp8 so there should be no difference in treatment. Attempts to use dst scales with non-fp8 float dst will be filtered in attr checks.
kealan-barbieri
force-pushed
the
kealanba/compute_backports
branch
2 times, most recently
from
8aa5c64 to
accacad
Compare
kealan-barbieri
force-pushed
the
kealanba/compute_backports
branch
from
accacad to
606af26
Compare
|
make test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backport of mixed fp8 support, additional scale support for compute primitivies.
Checklist
General
make testandmake test_benchdnn_*) pass locally for each commit?