Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OneDNN rls-v3.6.2 #2240

Merged
merged 25 commits into from
Dec 4, 2024
Merged

OneDNN rls-v3.6.2 #2240

merged 25 commits into from
Dec 4, 2024

Conversation

Radu2k
Copy link
Contributor

@Radu2k Radu2k commented Dec 2, 2024

Release notes

This release comes with AArch64 improvements, updates Arm Compute Library to 24.11.1 version and includes critical bug fixes.

f30310e fix, build, docs: aarch64: mutex lock if the ACL kernel is not stateless
ccb3ef1 github: workflows: Reduce MacOS CI configs for faster testing
be16835 gtests: graph: workaround gcc compilation issue
937c658 fixup: common: utils: array_copy: remove specific diagnostics from the function
7f23c16 github: workflows: bump actions/checkout from 4.1.7 to 4.2.2
3dd6aa6 common: utils: array_copy: remove specific diagnostics from the function
5488e8c cmake: ignore GCC specific flags that produce false-positives
a98722c github: workflows: disable testcase for graph mqa on macos aarch64 CI
60c0002 github: workflows: Enable ACL caching for aarch64 ci
2056fe0 github: workflows: Enable aarch64 CI (#2142)
4273854 github: workflows: Add initial linux aarch64 runners
a477aef cpu: aarch64: turn on ci DONEDNN_WERROR
a37c19d github: workflows: Add macos smoke tests
a13e099 github: workflows: harden GitHub actions
ac9c3d0 cpu: aarch64: brgemm: Fix unimplemented conditions for brgemm (#2148)
f36b049 cpu: aarch64: Expand brgemm aarch64 unsupported cases handling mechanism (#2099)
0de7263 cpu: aarch64: Re-enable ACL indirect conv for BF16
373bc5b test: aarch64: Fix unimplemented error when --cpu-isa-hints=prefer_ymm (#2208)
b8bdd63 cpu: aarch64: enable bf16f32 matmul benchdnn
872ecac src: cpu: aarch64: Enable jit bf16 -> f32 reorder (#2206)
b3be239 cpu: aarch64: fix acl matmul dim guard for 4d tensor broadcast
583215d aarch64: fix out-of-bound warnings of deconvolution
d66a391 aarch64: fix jit_brgemm warnings
ec935d0 cpu : aarch64 : reorder : zp correction for 4d shapes (#2224)
db5e699 cpu : aarch64 : reorder : reenabled bf16 jit uni reorders

@github-actions github-actions bot added documentation A request to change/fix/improve the documentation. Codeowner: @oneapi-src/onednn-doc platform:cpu-aarch64 Codeowner: @oneapi-src/onednn-cpu-aarch64 devops Github automation backport labels Dec 2, 2024
Shreyas-fuj and others added 9 commits December 2, 2024 20:56
benchdnn: `ONEDNN_VERBOSE=all ./benchdnn --matmul --dt=bf16:bf16:f32 32x128:128x32`
Before:
 onednn_verbose,v1,primitive,create:dispatch,matmul,cpu,matmul,gemm:acl,undef,src:bf16:a:any:any::f0 wei:bf16:a:any:any::f0 dst:f32:a:any:any::f0,,,32x128:128x32,unsupported datatype combination,src/cpu/aarch64/matmul/acl_matmul.cpp:89
After: (picks up ACL kernel)
 onednn_verbose,v1,primitive,exec:external,CpuGemmAssemblyWrapperKernel/sve_ffhybrid_bf16fp32_mmla_6x4VL,0.242188
 onednn_verbose,v1,primitive,exec,cpu,matmul,gemm:acl,undef,src:bf16:a:blocked:ab::f0 wei:bf16:a:blocked:BA8b4a::f0 dst:f32:a:blocked:ab::f0,,,32x128:128x32,0.267822
@Radu2k Radu2k force-pushed the rls-v3.6 branch 2 times, most recently from 56e122d to 50ba45d Compare December 2, 2024 21:46
step-security-bot and others added 12 commits December 2, 2024 22:26
Signed-off-by: StepSecurity Bot <[email protected]>
Change-Id: Ie5df8d70a222e5e2b744ce32c1a653272646b167
Signed-off-by: Hamza Butt <[email protected]>
Change-Id: Ice78e9e8209fbe5bac6b815c174f118c61fb0f07
- Introduce cross-platform ci scripts.
- Add Arm hosted github runners.
- Add build/test for OMP and SEQ backends.

Signed-off-by: Hamza Butt <[email protected]>
Change-Id: I43484e94364f9b18978f45cba1d4be980c20abdf
Signed-off-by: Hamza Butt <[email protected]>
Change-Id: Ie1529bcc22fae942c17fc40688dad7672d59f79c
- Downgrade GCC to v13 on Mac to fix warnings.
- Help improve ci throughput significantly.
Signed-off-by: Ye Tao <[email protected]>
Change-Id: I2a9d1d2c4c70d445ad718a82808e26f99108a72f
Change-Id: I1d9e0700dc2a5473f1f64fdf187c614f7f2e5f21
Bumps [actions/checkout](https://github.com/actions/checkout) from 4.1.7 to 4.2.2.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v4.1.7...11bd719)

Change-Id: I70dc87e67ba29ade5fc96623d5bf8de870e3f1ec

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Wrap a single function to avoid warning removal for the whole library
since only a single test is affected.
This feature depends on ACL >= 24.11.1 so the build system and docs have
been updated to reflect that.

Signed-off-by: Siddhartha Menon <[email protected]>
(cherry picked from commit f30310e)
@Radu2k Radu2k marked this pull request as ready for review December 3, 2024 13:37
@Radu2k Radu2k requested review from a team as code owners December 3, 2024 13:37
Copy link
Contributor

@ranukund ranukund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The .md file looks good, thanks!

Copy link
Contributor

@TaoLv TaoLv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I reviewed graph component changes.

@mgouicem mgouicem merged commit 4d962e7 into oneapi-src:rls-v3.6 Dec 4, 2024
22 checks passed
@vpirogov
Copy link
Member

vpirogov commented Dec 9, 2024

@theComputeKid, @milpuz01, updating minimal supported ACL version is a breaking change that does not belong in patch releases. Eas come up with better approach to manage minimal supported version for future releases.

@vpirogov vpirogov added this to the v3.6 milestone Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport devops Github automation documentation A request to change/fix/improve the documentation. Codeowner: @oneapi-src/onednn-doc platform:cpu-aarch64 Codeowner: @oneapi-src/onednn-cpu-aarch64
Projects
None yet
Development

Successfully merging this pull request may close these issues.