gpu: amd: Enable SYCL kernels #2024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgeor255
changed the title
t4c1
approved these changes
Aug 6, 2024
vpirogov
added
platform:gpu-amd
|
I think the failing gtests on CI are not related to the changes in this PR. I am seeing similar failures on master when I run the tests locally. |
densamoilov
reviewed
Aug 7, 2024
sgeor255
force-pushed
the
svet/enable-sycl-kernels
branch
from
fe16e2e to
f12a48e
Compare
densamoilov
reviewed
Aug 7, 2024
sgeor255
changed the title
sgeor255
force-pushed
the
svet/enable-sycl-kernels
branch
from
f12a48e to
9a4f95e
Compare
densamoilov
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR enables the generic SYCL kernels on intel & AMD backends.
For AMD backend, a new internal cmake option was added (
DNNL_HIP_TARGET_ARCH) used to specify the AMD architecture to compile the kernels for. If the option is not passed, the kernels are not compiled and not added to the implementation lists.