Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix isBridgeContract handler in burner wallet plugin #467

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
+4 −1
Open

Fix isBridgeContract handler in burner wallet plugin #467

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion burner-wallet-plugin/tokenbridge-bw-exchange/src/utils/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,9 @@ export const isBridgeContract = async (contract: Contract, allowedModes?: string
}
return allowedModes.includes(mode)
} catch (e) {
return false
if (e.message.includes("Returned values aren't valid")) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is your advise to verify this functionality with the Infura or xDai rpc endpoints?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, I would suggest to add an additional console.log statement here, which will print out the e.message, so that we can see what kind of errors get in different situations.
In my local experiments, the error starting from Returned values aren't valid happened only when the callee was either an EOA or some non-bridge contract. Also, seems that this error is raised from the web3js library, so the error message should not depend on the particular JSON-RPC implementation.

return false
}
throw e
}
}