Develop -> Master (SonarCloud Warnings Fixes) #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 17 commits
May 27, 2024 13:20
…Closure Fix SonarCloud Empty Closure warning
Fix SonarCloud "Cognitive Complexity" warning in BadRequestReason
Fix SonarCloud "Cognitive Complexity" warning in CreditCardPaymentController
…DateTextField Fix SonarCloud "Cognitive Complexity" warning in CardExpiryDateTextField
…oller Fix SonarCloud "Cognitive Complexity" warning in NetceteraThreeDSController
Fix SonarCloud "Cognitive Complexity" warning in OmiseError's BadRequestReason (2)
vault087
changed the title
Sync develop with master
Fix discover card and add unionPay
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix SonarCloud warning in "Refactor this function to reduce its Cognitive Complexity from [xx] to the 15 allowed" in
Fixed SonarCloud issues of type “Add a nested comment explaining why this closure is empty, or complete the implementation.”