Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate Models, Enums, Params and Requests #38

Open
wants to merge 45 commits into
base: master
Choose a base branch
from

Conversation

rezigned
Copy link
Contributor

@rezigned rezigned commented Oct 7, 2019

Main tasks

  • Models
  • Enums
  • Resources (Need a redesign to make it more corresponds to API endpoint)
  • Request Params ( renamed from {Action}Request to {Action}Params )
  • Delete all *Request.cs
  • Move *Params to Params/*.cs
  • Fix failed tests (WIP)
  • Pin 2019 API version
  • Fix DisputeResource's statuses

Changes

  • Rename OffsiteTypes to SourceType
  • Rename PaymentSource to Source
  • Move testdata/ dir to Omise.Tests
  • Remove Omise.Tests T4 template for fixtures (we don't have to re-run T4 every time when we add new fixtures)
  • Remove Omise/Modets.tt 🎉
  • Use dotnet test
  • Use Github Action
  • Migrate Makefile to use dotnet commands
  • Update version to 3.0.0

@NattawatPin
Copy link

When we can use this on nuget?

@rezigned rezigned force-pushed the codegen branch 2 times, most recently from 0a62de0 to 25006df Compare March 10, 2020 08:29
@rezigned
Copy link
Contributor Author

@NattawatPin Since this is a major release and it involves a re-design and breaking changes. We don't have a specific date yet. But we'll keep you posted.

@rezigned rezigned changed the title Generate Models, Enums and Requests (wip) Generate Models, Enums, Params and Requests (wip) Apr 10, 2020
@rezigned rezigned changed the title Generate Models, Enums, Params and Requests (wip) Generate Models, Enums, Params and Requests Sep 16, 2020
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 1 Security Hotspot
Code Smell A 46 Code Smells

No Coverage information No Coverage information
1.8% 1.8% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants