Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plugin dependencies to setup.py #30

Merged
merged 7 commits into from
Oct 21, 2020

Conversation

sbesson
Copy link
Member

@sbesson sbesson commented Oct 21, 2020

Also include classifiers and license

Also include classifiers and license
@sbesson
Copy link
Member Author

sbesson commented Oct 21, 2020

Noticed while working on #28 and #29 and trying to re-add all the dependencies of the plugin. With the last release of ome-zarr-py (ome/ome-zarr-py#55), scikit-image is also transitively declared as a dependency.

Minimally tested with

FROM centos:7

RUN yum install -y git python3 fontconfig
RUN useradd -ms /bin/bash zarr
USER zarr

RUN python3 -m venv /tmp/venv && /tmp/venv/bin/pip install -U pip wheel && /tmp/venv/bin/pip install https://github.com/ome/zeroc-ice-py-centos7/releases/download/0.2.1/zeroc_ice-3.6.5-cp36-cp36m-linux_x86_64.whl
RUN /tmp/venv/bin/pip install git+https://github.com/sbesson/omero-cli-zarr@plugin_dependencies

ENTRYPOINT ["/tmp/venv/bin/omero", "zarr", "-h"]

setup.py Outdated
author_email="",
license="",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was going to suggest something here, but ended up in a rabbit hole... pypa/packaging.python.org#95

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. https://packaging.python.org/guides/distributing-packages-using-setuptools/#license suggests that the classifiers should be the reference place for the project license in all cases. Happy to remove the license keyword if the vocabulary if unclear as I could not find a list of official terms either.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sbesson
Copy link
Member Author

sbesson commented Oct 21, 2020

I think the remaining pre-commit issues are now unrelated to this PR but to changes already merged on master

@joshmoore
Copy link
Member

Travis is gone in the mainline. Merging.

@joshmoore joshmoore merged commit 49d4308 into ome:master Oct 21, 2020
@sbesson sbesson deleted the plugin_dependencies branch October 21, 2020 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants