-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add plugin dependencies to setup.py #30
Conversation
Also include classifiers and license
Noticed while working on #28 and #29 and trying to re-add all the dependencies of the plugin. With the last release of Minimally tested with
|
setup.py
Outdated
author_email="", | ||
license="", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was going to suggest something here, but ended up in a rabbit hole... pypa/packaging.python.org#95
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed. https://packaging.python.org/guides/distributing-packages-using-setuptools/#license suggests that the classifiers
should be the reference place for the project license in all cases. Happy to remove the license
keyword if the vocabulary if unclear as I could not find a list of official terms either.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/ome/omero-py/blob/dab7f1790ec0c0b5f0db0beaf3948b328a41e469/setup.py#L179-L233 doesn't have a license
field and no-one's said anything.
I think the remaining pre-commit issues are now unrelated to this PR but to changes already merged on |
Travis is gone in the mainline. Merging. |
Also include classifiers and license