Preserve order of backends in BACKENDSCACHE #1004
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When I load backends with `load_backends`, it returns `BACKENDSCACHE`, which is unordered `dict`. It's very unhandy to order result later, so it would be nice, if `BACKENDSCACHE` kept order of backends passed as argument
|
Hello @omab do you need anything else to merge this request? |
|
@tsouvarev, the PR looks good, but I'm in the middle of splitting the application in smaller pieces (core, django, flask, etc), I'll port any PR to the corresponding place once I've finish the split/migration |
|
thanks, looking forward to that |
omab
force-pushed
the
master
branch
2 times, most recently
from
1078c07 to
de9f179
Compare
|
I've ported this PR into social-core. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I load backends with
load_backends, it returnsBACKENDSCACHE, which is unordereddict.It's very unhandy to order result later, so it would be nice, if
BACKENDSCACHEkept order of backends passed as argument