Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Working example with remix / cloudflare #1

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

geemanjs
Copy link
Contributor

No description provided.

@@ -1,16 +1,22 @@
import * as Sentry from "@sentry/remix";
import * as Sentry from "@sentry/cloudflare";
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great spot @geemanjs! 🙌 I'll raise an issue in the Sentry docs as their implementation mentions using the @sentry/remix import.

Copy link
Collaborator

@charlie-bud charlie-bud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@geemanjs Thanks for the detailed investigation and response you did on the initial issue, really appreciate your input! 🙌

There is definitely a variety of issues here. Lack of correct source-mapping is a nuisance for sure. Until Sentry have a better solution, just being able to get the error reported correctly, which this solution does (at least when building locally), is a great step forwards 🙌

@geemanjs
Copy link
Contributor Author

No problem! Completely agree, the source mapping is probably not too hard to solve for someone that understands source mapping well - sadly thats not me 🤣!

@charlie-bud charlie-bud merged commit ca3850f into ollie-bud:main Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants