redis_exporter v1.0.0

[oliver006]

This PR introduces breaking changes and will be released as v1.0.0

Why

This project was started over four years ago and a lot has changed since. This is an effort to get the redis_exporter to more closely adhere to the Best Practices for Writing Exporters and clean up the code.

The biggest change is that the exporter no longer directly supports configuring (and scraping) multiple redis instances but pushes that responsibility to the Prometheus server. If this is how you currently use the exporter, then have a look at this section how to configure the Prometheus server to scrape multiple instances.

However, if you already use the exporter as intended by the Prometheus project and scrape only one instance (and e.g. use the --redis.addr and --redis.password cmd line flags) then little to nothing will change for you.

Breaking changes in this PR:

• The exporter will no longer directly do any Service Discovery and/or scrape multiple redis instances at once.
  All this functionality should happen in the Prometheus server.
  You can still scrape multiple redis instances with one exporter, see the README for an example Prometheus server configuration.
  • this means all the addr and alias labels are gone, use Prometheus server label rewriting for this if need/want them back.
  • introduced /scrape endpoint to allow scraping a particular instance
    • fixes Parallelize requests #126 Parallelize requests
    • see the README for an example
• The exporter now uses ConstMetrics to correctly export counters and gauges. as per the best practices
  • fixes Export counters as counters #178 Export counters as counters
  • fixes promtool check metrics issues #204 fix promtool linting errors
• total_system_memory_bytes will not be included by default any longer, use a command line flag to include it anyway.
• renamed latency_spike_milliseconds -> latency_spike_seconds
• renamed all the cpu metrics to end with _seconds
• last_scrape_duration and scrape_error metrics are now per-instance (if you scrape multiple instances) and scrape_error includes the error as a label value
• Tile38 metrics are only scraped if --is-tile38 command line flag is set
• Put the release file in a folder inside the .tar.gz #173 Put the release file in a folder inside the .tar.gz

New features:

• related to Compose/ibmcloud redis exporter with ssl rediss:// does not work  #251 - added a flag to allow skipping cert validation
• Allow command renaming #146 allow overriding CONFIG command name

Todo

• remove 1.0.0-rc drone step
• fix up link to README in this PR to link to master for future reference

[codecov]

Codecov Report

❗ No coverage uploaded for pull request base (master@42235be). Click here to learn what that means.
The diff coverage is 81.56%.

@@           Coverage Diff            @@
##             master    #256   +/-   ##
========================================
  Coverage          ?   74.2%           
========================================
  Files             ?       2           
  Lines             ?     663           
  Branches          ?       0           
========================================
  Hits              ?     492           
  Misses            ?     143           
  Partials          ?      28

Impacted Files	Coverage Δ
main.go	0% <0%> (ø)
exporter.go	86.31% <89.51%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42235be...038b87b. Read the comment docs.

[oliver006]

[oliver006]

This is available on docker as v1.0.0-rc.1

docker run -d --name redis_exporter -p 9121:9121 oliver006/redis_exporter:v1.0.0-rc.1

[oliver006]

@SuperQ - this PR addresses the issue you raised in #228 - do you mind having a look, at the feature in particular and maybe the PR in general? Could always some more feedback here, esp if the general direction makes sense.

@brian-brazil - this PR addresses #31 that you raised a million years ago. Mind having a look if the general idea of the changes is somewhat sane? (cc @jkohen re: issue #178 )

[brian-brazil]

This looks better from a quick peek.

[oliver006]

Thanks @brian-brazil - that's good feedback.

[oliver006]

Let's do this.

[oliver006]

Github has issues with notifications right now, the exporter binaries and docker image for 1.0.0 will be available as soon as these have been resolved.

[roman-vynar]

The exporter will no longer directly do any Service Discovery and/or scrape multiple redis instances at once.

That's very sad. We are running multiple redis containers on a single instance which means we now need to run multiple redis_exporter processes :(

We use Prometheus and we do Service Discovery but we don't want to run multiple redis_exporters :(

[SuperQ]

You don't need multiple exporters. The new version can still scrape multiple redis instances. It is configured more like the blackbox exporter.

[oliver006]

@roman-vynar - see here for more information how to configure Prometheus to scrape multiple hosts.

[amangupta0297]

Hi,

Can anyone help me with redis exporter metrics
redis version: 3.0.3
redis-exporter version: 1.10.0
exporter running at : 9121
grafana dashboard: 763

prometheus config:

• job_name: 'redis_exporter'
  static_configs:
  • targets: ['DNS:9121']

target is healthy under prometheus, but still data is not coming over grafana.

When i see, the metrics

curl http://DNS:9121/metrics | grep redis

redis_exporter_build_info{build_date="2018-09-20-18:15:12",commit_sha="8bb0b841e9a70b0348f69483e58fea01d521c47a",golang_version="go1.10.4",version="v0.21.2"} 1
redis_exporter_last_scrape_duration_seconds 0.000292674
redis_exporter_last_scrape_error 1
redis_exporter_scrapes_total 125
redis_up{addr="redis://localhost:6379",alias=""} 0

issue: only very few metrics are coming, because of which data is not coming over grafana.

metrics required:

1. redis_uptime_in_seconds
2. redis_connected_clients
3. redis_memory_used_bytes/ redis_memory_max_bytes

none of the data is coming, can anyone help. What am i missing

Thanks in advance