Change Merkle Tree to linear data structure #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cliff0412
reviewed
Feb 29, 2024
| print_time(now, "fill init"); | ||
| let now = Instant::now(); | ||
|
|
||
| // copy data to C |
There was a problem hiding this comment.
we could use rust to copy directly?
There was a problem hiding this comment.
fill_digests_buf_gpu_v2() copies directly from Rust to the GPU, but the performance is lower compared to Rust -> C -> GPU. We need to investigate the reason
There was a problem hiding this comment.
Fixed this, now the performance is almost the same (maybe only 1ms difference).
|
suggest to reuse the data after lde inside GPU in cases where LDE is before merkle tree. or maybe we could use separate features or different size of data to control whether use LDE. currently, LDE is applied when log_n is > 10 (where gpu is faster). when log_n < 10, it will fall back to cpu code |
cliff0412
pushed a commit
that referenced
this pull request
Mar 18, 2024
* Remove values of last memory channel Co-authored-by: Linda Guiga <[email protected]> * Fix merge * Apply comments * Fix ASM * Top stack documentation (#7) * Add doc file * Apply comments * Apply comments * Fix visibility * Fix visibility --------- Co-authored-by: Linda Guiga <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original data structure for Merkle Tree in Plonky2 is recursive. This PR replaces this recursive data structure with a linear (typical binary tree array representation).